Skip to content

ci: Propagate yarn dist failure to AppVeyor - #2466

Merged
taratatach merged 1 commit into
masterfrom
ci/fail-on-yarn-dist-failure
Sep 8, 2026
Merged

ci: Propagate yarn dist failure to AppVeyor#2466
taratatach merged 1 commit into
masterfrom
ci/fail-on-yarn-dist-failure

Conversation

@taratatach

Copy link
Copy Markdown
Member

AppVeyor only fails a pwsh step on an uncaught exception; a
non-zero exit code from a native command like yarn dist leaves the
build green, as happened when the NSIS installer compilation broke.
Exit explicitly with $LASTEXITCODE so packaging errors mark the
build job as failed.

Please make sure the following boxes are checked:

  • PR is not too big
  • it improves UX & DX in some way
  • it includes unit tests matching the implementation changes
  • it includes scenarios matching a new behaviour or has been manually tested
  • it includes relevant documentation

@taratatach taratatach self-assigned this Sep 7, 2026
  AppVeyor only fails a `pwsh` step on an uncaught exception; a
  non-zero exit code from a native command like `yarn dist` leaves the
  build green, as happened when the NSIS installer compilation broke.
  Exit explicitly with `$LASTEXITCODE` so packaging errors mark the
  `build` job as failed.
@taratatach
taratatach force-pushed the ci/fail-on-yarn-dist-failure branch from a89bfa2 to 8fd0db0 Compare September 8, 2026 11:11
@taratatach
taratatach changed the base branch from feat/allow-users-to-delete-config-data-during-uninstall to master September 8, 2026 11:11
@taratatach
taratatach merged commit f2bda88 into master Sep 8, 2026
15 of 17 checks passed
@taratatach
taratatach deleted the ci/fail-on-yarn-dist-failure branch September 8, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant